-
Notifications
You must be signed in to change notification settings - Fork 48
Subgraph sander #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Subgraph sander #51
Conversation
- Most features are complete, correct ordering, layout based on subgraph - Additional minimal features to be implemented later, rank=same attribute
…imum subgraph level
|
THis implements subgraph feature using the algorithm defined in the paper by Sander. It looks pretty good for graphs I tried with claude Sander's paper: https://publikationen.sulb.uni-saarland.de/bitstream/20.500.11880/25862/1/tr-A03-96.pdf |
|
There is couple issues regarding public api changes. Due to addition of subgraph feature, one needs to specify subgraph in which the node is located. We can do this via two ways More precisely, |
azriel91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heya! I tried this out on the html-subgraph branch, and hit a case where the code panics from invalid user input (a subgraph with no nodes).
I could make sure not to send in invalid input, though I wonder if we should handle it here
Thanks for catching this. I implicitly assumed this in several places. (essentially due to logical continuation from the paper and the position of subgraph being determined by its child nodes) |
|
No description provided.